All writing
engineeringmentorship

Code review as a teaching tool

Reviews aren't just quality gates — they're the highest-leverage teaching surface a team has. Here's how I try to use them.

SP
Shane Perreault
Engineering Manager
4 min read

Most teams treat code review as a checkpoint: does this pass the bar to merge? That's fine, but it misses the bigger opportunity.

A code review is a conversation about how we build software here. Every comment is a chance to share context, explain a tradeoff, or invite a better idea.

The three kinds of comments I try to write

  1. "Here's why" — context the author probably doesn't have.
  2. "Have you considered" — an alternative, not a demand.
  3. "Ship it" — explicit approval, so the author isn't guessing.

What I try not to do

  • Nitpick style that a linter should catch.
  • Rewrite the PR in the review — if it's that off, pair on it.
  • Leave silence. Silence is the worst review of all.

The goal is a team that gets a little sharper every week.

Written by

Shane Perreault

Software engineer for 10+ years, currently an engineering manager. I write about the craft of building software and growing teams.

Subscribe

Never miss a post

Occasional notes on engineering, management, and craft. No spam, unsubscribe anytime.

Protected by reCAPTCHA — Privacy · Terms